allow for additional parameters when activating discovery service #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
requested changes
Sep 11, 2024
reinkrul
requested changes
Sep 11, 2024
| @@ -294,6 +294,11 @@ func matchFormat(format *PresentationDefinitionClaimFormatDesignations, credenti | |||
| return true | |||
| } | |||
|
|
|||
| if credential.Format() == "" { | |||
| // holder credential | |||
There was a problem hiding this comment.
what has holder credential (actually "issuer is holder"-credential) to do with format? Weird comment?
There was a problem hiding this comment.
Format is extracted from the proof. Holder credential has no Proof and thus no format.
There was a problem hiding this comment.
The credential can still be in either JWT (unsigned) or JSON-LD format?
There was a problem hiding this comment.
We have to rewrite some stuff. Let's hold that until VC data model 2 and it's new VC types. The two formats we're using now are gone in 202x?
gerardsn
approved these changes
Sep 11, 2024
reinkrul
approved these changes
Sep 13, 2024
woutslakhorst
deleted the
feature/3353_allow_holder_credentials_in_discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3353
closes #3352
also returns the params with a search.