Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignJWS: always add kid to header #3499

Merged
merged 1 commit into from
Oct 18, 2024
Merged

SignJWS: always add kid to header #3499

merged 1 commit into from
Oct 18, 2024

Conversation

gerardsn
Copy link
Member

closes #3488

woutslakhorst
woutslakhorst approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to mark those sign APIs as deprecated in the futuer (not used)

@gerardsn gerardsn merged commit 4e53223 into master Oct 18, 2024
9 checks passed
@gerardsn gerardsn deleted the fix-3488/fix-SignJWS-audit-log branch October 18, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@reinkrul reinkrul Awaiting requested review from reinkrul reinkrul is a code owner

@stevenvegt stevenvegt Awaiting requested review from stevenvegt stevenvegt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crypto: SignJWS and SignJWT don't log all key operations
2 participants
@gerardsn @woutslakhorst