reenable CORS for IRMA #3571
Merged
reenable CORS for IRMA #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
requested review from
reinkrul,
gerardsn and
stevenvegt
as code owners
test fix
woutslakhorst
force-pushed
the
fix/3570/reenable_cord_middleware
branch
from
d588ff4 to
28f4efd
Compare
reinkrul
approved these changes
Nov 20, 2024
| @@ -51,6 +54,7 @@ func FlagSet() *pflag.FlagSet { | |||
| defs := auth.DefaultConfig() | |||
| flags.String(ConfIrmaSchemeManager, defs.Irma.SchemeManager, "IRMA schemeManager to use for attributes. Can be either 'pbdf' or 'irma-demo'.") | |||
| flags.Bool(ConfAutoUpdateIrmaSchemas, defs.Irma.AutoUpdateSchemas, "set if you want automatically update the IRMA schemas every 60 minutes.") | |||
| flags.StringSlice(ConfIrmaCorsOrigin, defs.Irma.CORS.Origin, "sets the allowed CORS origins for the IRMA server") | |||
There was a problem hiding this comment.
A note for what the behavior is when not set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3570
Can be released with v6.1
Tested by hand with
and config