helm: add extraVolumes and extraVolumeMounts values#4068
Open
cschuijt wants to merge 1 commit intonuts-foundation:masterfrom
Open
helm: add extraVolumes and extraVolumeMounts values#4068cschuijt wants to merge 1 commit intonuts-foundation:masterfrom
cschuijt wants to merge 1 commit intonuts-foundation:masterfrom
Conversation
cschuijt
requested review from
gerardsn,
reinkrul,
stevenvegt and
woutslakhorst
as code owners
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
extraVolumesandextraVolumeMountskeys to the helm chart values, so it becomes possible to mount custom volumes/configmaps/secrets in the nuts node pod. Yaml from those keys is copied as-is onto the deployment.I also took the liberty of bumping the chart version, since that seemed to be the desired workflow in #3935.