Add GitHub Actions workflow to build and push Docker images #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow triggers on commits to the master branch and tag pushes. It builds and pushes Docker images for both release and development versions, supporting multiple architectures.
Added 'build-images' branch to the workflow trigger for push requests.
gerardsn
requested changes
Nov 28, 2024
Comment on lines
+87
to
+94
| - name: Build and push development image | ||
| if: ${{ github.event_name != 'pull_request' && github.ref == 'refs/heads/master'}} | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: development/dev-image | ||
| push: true | ||
| platforms: linux/amd64,linux/arm64 | ||
| tags: nutsfoundation/nuts-node:dev |
There was a problem hiding this comment.
probably no dev image needed. (also wrong tag)
| id: docker_meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: nutsfoundation/nuts-node |
There was a problem hiding this comment.
this should not go under nutsfoundation/nuts-node
Comment on lines
+67
to
+72
| - name: Login to Docker Hub | ||
| if: ${{ github.event_name != 'pull_request' }} | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} |
There was a problem hiding this comment.
pushing this to docker would require setting up branch protection and mandatory code reviews etc. Maybe better to wait a bit and just build locally when needed
gerardsn
requested changes
Nov 28, 2024
17 tasks
|
this also requires strict branch protection and reviews from code owners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow triggers on commits to the master branch and tag pushes. It builds and pushes Docker images for both release and development versions, supporting multiple architectures.