Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode accented letters as well #40

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Encode accented letters as well #40

merged 3 commits into from
Dec 18, 2024

Conversation

reinkrul
Copy link
Member

Fixes #39

@reinkrul reinkrul requested a review from stevenvegt December 17, 2024 10:26
stevenvegt
stevenvegt approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reinkrul reinkrul merged commit 8982367 into main Dec 18, 2024
3 checks passed
@reinkrul reinkrul deleted the escape-accented-letters branch December 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenvegt stevenvegt stevenvegt approved these changes

@gerardsn gerardsn Awaiting requested review from gerardsn

@woutslakhorst woutslakhorst Awaiting requested review from woutslakhorst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DID url pattern does not support accented letters
2 participants
@reinkrul @stevenvegt