Bump pycodestyle from 2.11.0 to 2.11.1 in /tools/deps (#4484)

* Bump pycodestyle from 2.11.0 to 2.11.1 in /tools/deps

* Bump codespell from 2.2.4 to 2.2.6 in /tools/deps (#4211)

* Bump pytest-timeout from 2.0.2 to 2.2.0 in /tools/deps (#4226)

* Bump responses from 0.23.3 to 0.24.1 in /tools/deps (#4457)

* Bump black from 23.9.1 to 23.12.1 in /tools/deps (#4456)

* Bump vulture from 2.9.1 to 2.10 in /tools/deps (#4485)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: poojadaine <126543069+poojadaine@users.noreply.github.com>
Co-authored-by: swetayadav1 <sweta.yadav@hyland.com>

docs/behaviors/Adobe Creative Suite.md

@@ -187,7 +187,7 @@ So, this does not work either.
 
 We could use the Photoshop Scripting API. I uses COM objects on Windows and AppleScript on macOS.
 
-I read that we can setup a `Notifer` that will call a function on specified a event.
+I read that we can setup a `Notifier` that will call a function on specified a event.
 
 This is a non working POC for Windows (requires the `pywin32` module):
 

docs/changes/5.5.0.md

@@ -34,21 +34,26 @@ Release date: `2024-xx-xx`
 
 - Upgraded `actions/download-artifact` from 3 to 4
 - Upgraded `actions/upload-artifact` from 3 to 4
+- Upgraded `black` from 23.9.1 to 23.12.1
 - Upgraded `boto3` from 1.28.50 to 1.34.17
 - Upgraded `botocore` from 1.31.50 to 1.34.17
+- Upgraded `codespell` from 2.2.4 to 2.2.6
 - Upgraded `cryptography` from 41.0.2 to 41.0.7
 - Upgraded `docker/build-push-action` from 5.0.0 to 5.1.0
 - Upgraded `faker` from 19.6.2 to 22.0.0
 - Upgraded `identify` from 2.5.29 to 2.5.33
 - Upgraded `idna` from 3.4 to 3.6
+- Upgraded `pycodestyle` from 2.11.0 to 2.11.1
 - Upgraded `pyobjc-core` from 7.3 to 10.1
 - Upgraded `pyobjc-framework-cocoa` from 7.3 to 10.1
 - Upgraded `pyobjc-framework-coreservices` from 7.3 to 10.1
 - Upgraded `pyobjc-framework-fsevents` from 7.3 to 10.1
 - Upgraded `pyobjc-framework-scriptingbridge` from 7.3 to 10.1
 - Upgraded `pyobjc-framework-systemconfiguration` from 7.3 to 10.1
+- Upgraded `pytest-timeout` from 2.0.2 to 2.2.0
+- Upgraded `responses` from 0.23.3 to 0.24.1
 - Upgraded `s3transfer` from 0.6.0 to 0.10.0
-
+- Upgraded `vulture` from 2.9.1 to 2.10
 ## Technical Changes
 
 -

mypy.ini

@@ -13,7 +13,7 @@ disallow_untyped_defs = True
 disallow_incomplete_defs = True
 disallow_untyped_calls = True
 
-# Should not be used until we find a way to annoate Qt slots
+# Should not be used until we find a way to annotate Qt slots
 # disallow_untyped_decorators = True
 
 # Restrict dynamic typing (a little)

nxdrive/autolocker.py

@@ -173,7 +173,7 @@ def get_open_files() -> Iterator[Item]:
             # But we also want to filter out errors by processor to be able to retrieve some data from others
             with suppress(Exception):
                 for handler in proc.open_files():
-                    # And so for errors happening at the processus level (typically PermissisonError's)
+                    # And so for errors happening at the processes level (typically PermissisonError's)
                     with suppress(Exception):
                         yield proc.pid, Path(handler.path)
     except Exception:

nxdrive/gui/folders_treeview.py

@@ -232,7 +232,7 @@ def expand_current_selected(self) -> None:
         self.expand_item(self.current)
 
     def select_item_from_path(self, new_remote_path: str) -> None:
-        """Find and select an itme in the tree view based in the *new_remote_path*."""
+        """Find and select an item in the tree view based in the *new_remote_path*."""
         item = self.model().itemFromIndex(self.current)
         for idx in range(item.rowCount()):
             child = item.child(idx)

nxdrive/osi/linux/linux.py

@@ -167,7 +167,7 @@ def _icons_to_emblems(self) -> None:
             try:
                 identical = filecmp.cmp(icon, emblem, shallow=False)
             except OSError:
-                # Most likely the *icon* doest not exist yet
+                # Most likely the *icon* does not exist yet
                 pass
             else:
                 if identical:

tests/old_functional/test_transfer.py

@@ -831,7 +831,7 @@ def callback(uploader):
 
     def test_app_crash_simulation(self):
         """
-        When the app crahsed, ongoing transfers will be removed at the next run.
+        When the app crashed, ongoing transfers will be removed at the next run.
         See NXDRIVE-2186 for more information.
 
         To reproduce the issue, we suspend the transfer in the upload's callback,

tools/changelog.py

@@ -217,7 +217,7 @@ def get_issue_infos(issue, raw=False):
         infos["components"].append(component["name"])
 
     try:
-        # We are not authentificated, so we cannot know the SUPNXP issue but
+        # We are not authenticated, so we cannot know the SUPNXP issue but
         # we can know that there is a related SUPNXP and set the issue as
         # high prioriy.
         if "SupCom" in data["fields"]["customfield_10080"]:

tools/check-spell.sh

@@ -8,7 +8,7 @@ check_spell() {
     echo "* Add '--interactive=3 --write-changes' arguments to the following command to allow interactive modifications."
 
     for file in tools/spell.skip .gitignore; do
-        # Small santitization:
+        # Small sanitization:
         #   - skip empty lines and comments
         #   - strip inline comments
         excludes="$(sed '/^\s*$/d ; /^#.*$/d ; s/\s*#.*$//' "${file}")"

tools/deps/requirements-tests.txt

@@ -15,36 +15,36 @@ attrs==23.1.0 \
     --hash=sha256:1f28b4522cdc2fb4256ac1a020c78acf9cba2c6b461ccd2c126f3aa8e8335d04 \
     --hash=sha256:6279836d581513a26f1bf235f9acd333bc9115683f14f7e8fae46c98fc50e015
     # via pytest
-black==23.9.1 \
-    --hash=sha256:031e8c69f3d3b09e1aa471a926a1eeb0b9071f80b17689a655f7885ac9325a6f \
-    --hash=sha256:13a2e4a93bb8ca74a749b6974925c27219bb3df4d42fc45e948a5d9feb5122b7 \
-    --hash=sha256:13ef033794029b85dfea8032c9d3b92b42b526f1ff4bf13b2182ce4e917f5100 \
-    --hash=sha256:14f04c990259576acd093871e7e9b14918eb28f1866f91968ff5524293f9c573 \
-    --hash=sha256:24b6b3ff5c6d9ea08a8888f6977eae858e1f340d7260cf56d70a49823236b62d \
-    --hash=sha256:403397c033adbc45c2bd41747da1f7fc7eaa44efbee256b53842470d4ac5a70f \
-    --hash=sha256:50254ebfa56aa46a9fdd5d651f9637485068a1adf42270148cd101cdf56e0ad9 \
-    --hash=sha256:538efb451cd50f43aba394e9ec7ad55a37598faae3348d723b59ea8e91616300 \
-    --hash=sha256:638619a559280de0c2aa4d76f504891c9860bb8fa214267358f0a20f27c12948 \
-    --hash=sha256:6a3b50e4b93f43b34a9d3ef00d9b6728b4a722c997c99ab09102fd5efdb88325 \
-    --hash=sha256:6ccd59584cc834b6d127628713e4b6b968e5f79572da66284532525a042549f9 \
-    --hash=sha256:75a2dc41b183d4872d3a500d2b9c9016e67ed95738a3624f4751a0cb4818fe71 \
-    --hash=sha256:7d30ec46de88091e4316b17ae58bbbfc12b2de05e069030f6b747dfc649ad186 \
-    --hash=sha256:8431445bf62d2a914b541da7ab3e2b4f3bc052d2ccbf157ebad18ea126efb91f \
-    --hash=sha256:8fc1ddcf83f996247505db6b715294eba56ea9372e107fd54963c7553f2b6dfe \
-    --hash=sha256:a732b82747235e0542c03bf352c126052c0fbc458d8a239a94701175b17d4855 \
-    --hash=sha256:adc3e4442eef57f99b5590b245a328aad19c99552e0bdc7f0b04db6656debd80 \
-    --hash=sha256:c46767e8df1b7beefb0899c4a95fb43058fa8500b6db144f4ff3ca38eb2f6393 \
-    --hash=sha256:c619f063c2d68f19b2d7270f4cf3192cb81c9ec5bc5ba02df91471d0b88c4c5c \
-    --hash=sha256:cf3a4d00e4cdb6734b64bf23cd4341421e8953615cba6b3670453737a72ec204 \
-    --hash=sha256:cf99f3de8b3273a8317681d8194ea222f10e0133a24a7548c73ce44ea1679377 \
-    --hash=sha256:d6bc09188020c9ac2555a498949401ab35bb6bf76d4e0f8ee251694664df6301
+black==23.12.1 \
+    --hash=sha256:0808494f2b2df923ffc5723ed3c7b096bd76341f6213989759287611e9837d50 \
+    --hash=sha256:1fa88a0f74e50e4487477bc0bb900c6781dbddfdfa32691e780bf854c3b4a47f \
+    --hash=sha256:25e57fd232a6d6ff3f4478a6fd0580838e47c93c83eaf1ccc92d4faf27112c4e \
+    --hash=sha256:2d9e13db441c509a3763a7a3d9a49ccc1b4e974a47be4e08ade2a228876500ec \
+    --hash=sha256:3e1b38b3135fd4c025c28c55ddfc236b05af657828a8a6abe5deec419a0b7055 \
+    --hash=sha256:3fa4be75ef2a6b96ea8d92b1587dd8cb3a35c7e3d51f0738ced0781c3aa3a5a3 \
+    --hash=sha256:4ce3ef14ebe8d9509188014d96af1c456a910d5b5cbf434a09fef7e024b3d0d5 \
+    --hash=sha256:4f0031eaa7b921db76decd73636ef3a12c942ed367d8c3841a0739412b260a54 \
+    --hash=sha256:602cfb1196dc692424c70b6507593a2b29aac0547c1be9a1d1365f0d964c353b \
+    --hash=sha256:6d1bd9c210f8b109b1762ec9fd36592fdd528485aadb3f5849b2740ef17e674e \
+    --hash=sha256:78baad24af0f033958cad29731e27363183e140962595def56423e626f4bee3e \
+    --hash=sha256:8d4df77958a622f9b5a4c96edb4b8c0034f8434032ab11077ec6c56ae9f384ba \
+    --hash=sha256:97e56155c6b737854e60a9ab1c598ff2533d57e7506d97af5481141671abf3ea \
+    --hash=sha256:9c4352800f14be5b4864016882cdba10755bd50805c95f728011bcb47a4afd59 \
+    --hash=sha256:a4d6a9668e45ad99d2f8ec70d5c8c04ef4f32f648ef39048d010b0689832ec6d \
+    --hash=sha256:a920b569dc6b3472513ba6ddea21f440d4b4c699494d2e972a1753cdc25df7b0 \
+    --hash=sha256:ae76c22bde5cbb6bfd211ec343ded2163bba7883c7bc77f6b756a1049436fbb9 \
+    --hash=sha256:b18fb2ae6c4bb63eebe5be6bd869ba2f14fd0259bda7d18a46b764d8fb86298a \
+    --hash=sha256:c04b6d9d20e9c13f43eee8ea87d44156b8505ca8a3c878773f68b4e4812a421e \
+    --hash=sha256:c88b3711d12905b74206227109272673edce0cb29f27e1385f33b0163c414bba \
+    --hash=sha256:dd15245c8b68fe2b6bd0f32c1556509d11bb33aec9b5d0866dd8e2ed3dba09c2 \
+    --hash=sha256:e0aaf6041986767a5e0ce663c7a2f0e9eaf21e6ff87a5f95cbf3675bfd4c41d2
 click==8.0.1 \
     --hash=sha256:fba402a4a47334742d782209a7c79bc448911afe1149d07bdabdf480b3e2f4b6 \
     --hash=sha256:8c04c11192119b1ef78ea049e0a6f0463e4c48ef00a30160c704337586f3ad7a
     # via black
-codespell==2.2.4 \
-    --hash=sha256:0b4620473c257d9cde1ff8998b26b2bb209a35c2b7489f5dc3436024298ce83a \
-    --hash=sha256:7d984b8130108e6f82524b7d09f8b7bf2fb1e398c5d4b37d9e2bd310145b3e29
+codespell==2.2.6 \
+    --hash=sha256:9ee9a3e5df0990604013ac2a9f22fa8e57669c827124a2e961fe8a1da4cacc07 \
+    --hash=sha256:a8c65d8eb3faa03deabab6b3bbe798bea72e1799c7e9e955d57eca4096abcff9
 colorama==0.4.4; sys_platform == "win32" \
     --hash=sha256:9f47eda37229f68eee03b24b9748937c7dc3868f906e8ba69fbcbdd3bc5dc3e2
     # via pytest
@@ -209,9 +209,9 @@ py==1.10.0 \
     --hash=sha256:3b80836aa6d1feeaa108e046da6423ab8f6ceda6468545ae8d02d9d58d18818a \
     --hash=sha256:21b81bda15b66ef5e1a777a21c4dcd9c20ad3efd0b3f817e7a809035269e1bd3
     # via pytest
-pycodestyle==2.11.0 \
-    --hash=sha256:259bcc17857d8a8b3b4a2327324b79e5f020a13c16074670f9c8c8f872ea76d0 \
-    --hash=sha256:5d1013ba8dc7895b548be5afb05740ca82454fd899971563d2ef625d090326f8
+pycodestyle==2.11.1 \
+    --hash=sha256:41ba0e7afc9752dfb53ced5489e89f8186be00e599e712660695b7a75ff2663f \
+    --hash=sha256:44fe31000b2d866f2e41841b18528a505fbd7fef9017b04eff4e2648a0fadc67
     # via flake8
 pyflakes==3.1.0 \
     --hash=sha256:4132f6d49cb4dae6819e5379898f2b8cce3c5f23994194c24b77d5da2e36f774 \
@@ -231,9 +231,9 @@ pytest-forked==1.6.0 \
     --hash=sha256:4dafd46a9a600f65d822b8f605133ecf5b3e1941ebb3588e943b4e3eb71a5a3f \
     --hash=sha256:810958f66a91afb1a1e2ae83089d8dc1cd2437ac96b12963042fbb9fb4d16af0
     # via pytest-xdist
-pytest-timeout==2.0.2 \
-    --hash=sha256:fe9c3d5006c053bb9e062d60f641e6a76d6707aedb645350af9593e376fcc717 \
-    --hash=sha256:e6f98b54dafde8d70e4088467ff621260b641eb64895c4195b6e5c8f45638112
+pytest-timeout==2.2.0 \
+    --hash=sha256:3b0b95dabf3cb50bac9ef5ca912fa0cfc286526af17afc806824df20c2f72c90 \
+    --hash=sha256:bde531e096466f49398a59f2dde76fa78429a09a12411466f88a07213e220de2
 pytest-xdist==3.3.1 \
     --hash=sha256:d5ee0520eb1b7bcca50a60a518ab7a7707992812c578198f8b44fdfac78e8c93 \
     --hash=sha256:ff9daa7793569e6a68544850fd3927cd257cc03a7ef76c95e86915355e82b5f2
@@ -333,9 +333,9 @@ regex==2023.8.8 \
     --hash=sha256:f2200e00b62568cfd920127782c61bc1c546062a879cdc741cfcc6976668dfcf \
     --hash=sha256:fcbdc5f2b0f1cd0f6a56cdb46fe41d2cce1e644e3b68832f3eeebc5fb0f7712e
     # via black
-responses==0.23.3 \
-    --hash=sha256:205029e1cb334c21cb4ec64fc7599be48b859a0fd381a42443cdd600bfe8b16a \
-    --hash=sha256:e6fbcf5d82172fecc0aa1860fd91e58cbfd96cee5e96da5b63fa6eb3caa10dd3
+responses==0.24.1 \
+    --hash=sha256:a2b43f4c08bfb9c9bd242568328c65a34b318741d3fab884ac843c5ceeb543f9 \
+    --hash=sha256:b127c6ca3f8df0eb9cc82fd93109a3007a86acb24871834c47b77765152ecf8c
 selenium==3.141.0 ; sys_platform == "win32" \
     --hash=sha256:2d7131d7bc5a5b99a2d9b04aaf2612c411b03b8ca1b1ee8d3de5845a9be2cb3c
 text-unidecode==1.3 \
@@ -413,9 +413,9 @@ types-requests==2.26.1 \
     --hash=sha256:853571b3accc188976c0f4feffcaebf6cdfc170082b5e43f3358aa78de61f531 \
     --hash=sha256:0893e112e1510bbb67f537941c92192de7472e51bf7f236e0e583866f0ed933e
     # via mypy
-vulture==2.9.1 \
-    --hash=sha256:a46857014619bd4b785a506b9ddb738cd4621043558309b03a879d18f86e2d72 \
-    --hash=sha256:b6a2aa632b6fd51488a8eeac650ab4a509bb1a032e81943817a8a2e6a63a30b3
+vulture==2.10 \
+    --hash=sha256:2a5c3160bffba77595b6e6dfcc412016bd2a09cd4b66cdf7fbba913684899f6f \
+    --hash=sha256:568a4176db7468d0157817ae3bb1847a19f1ddc629849af487f9d3b279bff77d
 wcwidth==0.2.6 \
     --hash=sha256:795b138f6875577cd91bba52baf9e445cd5118fd32723b460e30a0af30ea230e \
     --hash=sha256:a5220780a404dbe3353789870978e472cfe477761f06ee55077256e509b156d0

tools/spell.skip

@@ -18,3 +18,9 @@ tools/windows/unofficial_i18n
 # Hm, this seems weird but we also need to skip our own allow list ...
 tools/spell.allowlist
 tools/spell.skip
+
+# No need to check old_functional test cases, as we have the new functional test case suite
+tests/old_functional
+
+#This file is containing false positives, so skipping the file
+docs/changes/3.1.0.md

tools/windows/NuxeoDriveShellExtensions/NuxeoDriveUtil/json/json.h

@@ -984,7 +984,7 @@ class JSON_API ValueInternalLink {
 
 /** \brief A linked page based hash-table implementation used internally by
  *Value.
- * \internal ValueInternalMap is a tradional bucket based hash-table, with a
+ * \internal ValueInternalMap is a traditional bucket based hash-table, with a
  *linked
  * list in each bucket to handle collision. There is an additional twist in that
  * each node of the collision linked list is a page containing a fixed amount of

tox.ini

@@ -74,7 +74,7 @@ commands =
     python -m vulture nxdrive tools/skiplist.py
 
 [testenv:ft]
-description = Fuctional tests
+description = Functional tests
 envdir = {toxworkdir}/base
 passenv = {[base]passenv}
 deps = {[base]deps}
@@ -102,7 +102,7 @@ commands =
     python -m flake8 tools
 
 [testenv:oft]
-description = (old) Fuctional tests
+description = (old) Functional tests
 envdir = {toxworkdir}/base
 passenv = {[base]passenv}
 deps = {[base]deps}