Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use manifest 'name' for 'short_name' if provided #497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabrielchl
Copy link

The current default manifest short_name is the project package name, even when a custom name is provided for the manifest. This is not ideal as developers might assume that when name is provided, short_name would default to be the same as name, especially that it's optional (https://developer.mozilla.org/en-US/docs/Web/Manifest/short_name).

This patch uses the name value (if provided) for short_name, and otherwise uses the project package name as usual.

@gabrielchl gabrielchl changed the title Use manifest 'name' for 'short_name' if provided Fix: Use manifest 'name' for 'short_name' if provided Nov 13, 2021
@gabrielchl gabrielchl changed the title Fix: Use manifest 'name' for 'short_name' if provided fix: Use manifest 'name' for 'short_name' if provided Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant