fix: offline page precaching due to revision query parameter #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since PR #386 was merged (and possibly a new version of workbox), the offlinePage option of the documentation does not seem to work.
This is because since this PR, the cache identifier for the offline page now contains a WB_REVISION_ query parameter:
When we do
caches.match()
it tries to get the page without the query parameter and so it gets nothing.The workbox precaching module documentation page explains how to fix this:
This is what I'm doing in this PR, since we already precache the offlinePage.