Skip to content

feat(blob serve): stream option implemented to prevent videos downloading #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions docs/content/1.docs/2.features/blob.md
Original file line number Diff line number Diff line change
@@ -90,6 +90,8 @@ do {

Returns a blob's data and sets `Content-Type`, `Content-Length` and `ETag` headers.

#### Image

::code-group
```ts [server/routes/images/[...pathname\\].get.ts]
export default eventHandler(async (event) => {
@@ -105,6 +107,34 @@ export default eventHandler(async (event) => {
```
::

#### Video

::callout
Add `stream: true` option to prevent videos downloading.
::

::code-group
```ts [server/routes/videos/[...pathname\\].get.ts]
export default eventHandler(async (event) => {
const { pathname } = getRouterParams(event)

return hubBlob().serve(event, pathname, {
stream: true
})
})
```
```vue [pages/index.vue]
<template>
<video
controls
playsinline
controlsList="nodownload"
src="/videos/my-video.mp4"
/>
</template>
```
::

::important
To prevent XSS attacks, make sure to control the Content type of the blob you serve.
::
@@ -835,6 +865,14 @@ interface BlobListResult {
}
```

### `BlobServeOptions`

```ts
interface BlobServeOptions {
stream: boolean
}
```

## Examples

### List blobs with pagination
22 changes: 19 additions & 3 deletions src/runtime/blob/server/utils/blob.ts
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import { defu } from 'defu'
import { randomUUID } from 'uncrypto'
import { parse } from 'pathe'
import { joinURL } from 'ufo'
import type { BlobType, FileSizeUnit, BlobUploadedPart, BlobListResult, BlobMultipartUpload, HandleMPUResponse, BlobMultipartOptions, BlobUploadOptions, BlobPutOptions, BlobEnsureOptions, BlobObject, BlobListOptions, BlobCredentialsOptions, BlobCredentials } from '@nuxthub/core'
import type { BlobType, FileSizeUnit, BlobUploadedPart, BlobListResult, BlobMultipartUpload, HandleMPUResponse, BlobMultipartOptions, BlobUploadOptions, BlobPutOptions, BlobEnsureOptions, BlobObject, BlobListOptions, BlobCredentialsOptions, BlobCredentials, BlobServeOptions } from '@nuxthub/core'
import { streamToArrayBuffer } from '../../../utils/stream'
import { requireNuxtHubFeature } from '../../../utils/features'
import { getCloudflareAccessHeaders } from '../../../utils/cloudflareAccess'
@@ -56,7 +56,7 @@ interface HubBlob {
* })
* ```
*/
serve(event: H3Event, pathname: string): Promise<ReadableStream<any>>
serve(event: H3Event, pathname: string, options?: BlobServeOptions): Promise<ReadableStream<any>>
/**
* Put a new blob into the bucket.
*
@@ -192,7 +192,23 @@ export function hubBlob(): HubBlob {
folders: resolvedOptions.delimiter ? listed.delimitedPrefixes : undefined
}
},
async serve(event: H3Event, pathname: string) {
async serve(event: H3Event, pathname: string, options?: BlobServeOptions) {
const resolvedOptions = defu(options, {
stream: false
})

if (resolvedOptions?.stream) {
const referrer = getHeader(event, 'referer')
const range = getHeader(event, 'range')

if (!referrer || !range) {
throw createError({
statusCode: 403,
message: 'Unauthorized'
})
}
}

pathname = decodeURIComponent(pathname)
const object = await bucket.get(pathname)

4 changes: 4 additions & 0 deletions src/types/blob.ts
Original file line number Diff line number Diff line change
@@ -262,3 +262,7 @@ export interface BlobCredentials {
*/
sessionToken: string
}

export interface BlobServeOptions {
stream: boolean
}