-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add site.url
as an alternative to baseUrl
#2481
base: main
Are you sure you want to change the base?
Changes from all commits
c8cb6d8
130fa1c
8bfafd5
ea4a900
c83a50b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,6 +88,8 @@ | |
"knitwork": "^1.0.0", | ||
"magic-string": "^0.30.4", | ||
"mlly": "^1.4.2", | ||
"nuxt-site-config": "^1.4.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @harlan-zw https://nuxtseo.com/site-config/getting-started/installation specifies that |
||
"nuxt-site-config-kit": "^1.4.0", | ||
"pathe": "^1.1.1", | ||
"ufo": "^1.3.1", | ||
"unplugin": "^1.5.0", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,11 @@ defineI18nRoute({ | |
} | ||
}) | ||
|
||
const { t, locales, baseUrl } = useI18n({ | ||
const { t, locales } = useI18n({ | ||
useScope: 'local' | ||
}) | ||
console.log('locales', locales, baseUrl) | ||
const { url } = useSiteConfig() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: this should require enabling the |
||
console.log('locales', locales, url) | ||
</script> | ||
|
||
<template> | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there will need to be some documentation on all the ways that site config can be set and hosted on this page. The docs aren't that friendly at the moment, something on my to-do list.