-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add missing shared types #3212
Open
userquin
wants to merge
15
commits into
main
Choose a base branch
from
userquin/fix-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
userquin
changed the title
fix(types): add
fix(types): add missing shared types
Nov 10, 2024
types
to subpackage exports using module
dts
SB reproduction updated to use relative paths in nuxt config file (we cannot use nuxt aliases): registering also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #3201
β Type of change
π Description
Nuxt module builder generating module types in types dts (node and some runtime hooks types), we use it in the default package export, but internal types created in module dts, this PR just adds a new subpackage export./types
usingmodule.d.mts
with the types only and also including the subpackage insidetypesVersions
to include node10 consumers.This PR includes:
src/types.ts
to the build config file to add shared types to thetypes
dtstsc --noEmit
)This PR also changes the default subpackage export to use
default
insteadimport
(ESM only).π Checklist