-
Notifications
You must be signed in to change notification settings - Fork 46
refactor!: simplify module #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
angeloashmore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see so many lines removed! I left a few minor suggestion, but it looks good to me overall.
components.richTextComponentsis now configured atcomponentsConfig.defaultComponents, it now defaults to~/prismic/defaultComponentsinstead of~/prismic/richTextComponentspreviously (renamed as it also configures<PrismicTable>components)
I think it's okay to leave it as richTextComponents to avoid a breaking change. Tables contain rich text, so the name isn't invalid IMO.
Agreed, I reverted it on |
Note
Please refer to the upgrade guide for a smooth path forward!
Description
@prismicio/clientis now a peer dependency and needs to be installed explicitly.@prismicio/vuev6 is now used and comes with breaking changes.~/prismic/richTextSerializer(deprecated),~/prismic/linkRel,~/prismic/sliceZoneDefaultComponentare no longer proxied (and supported as defaults by@prismicio/vue). Create your own components with defaults instead if you need them.Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩