Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): remove cjs entrypoint #746

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix(devtools): remove cjs entrypoint #746

merged 1 commit into from
Oct 12, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

discovered in https://github.com/nuxt/ecosystem-ci/actions/runs/11286607655/job/31391242329, it seems that with new jiti upgrade we are loading the cjs version of devtools in the prepare step, which is flagging up an issue (this.nuxt doesn't work as this isn't defined) - cc: @pi0 in case this isn't expected

note, even this?.nuxt doesn't work as the dynamic import of ./dist/module.mjs doesn't work in the prepare step (before dist/module.mjs has been stubbed out)

I think it's safe to remove the cjs stub as it shouldn't be loaded by nuxt but you may have more context.

@danielroe danielroe requested a review from antfu October 11, 2024 15:45
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we requires Nuxt v3.9, I agree that cjs entry shouldn't be needed at all. Just in case any, I will release this as a minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants