fix(devtools): remove cjs entrypoint #746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
discovered in https://github.com/nuxt/ecosystem-ci/actions/runs/11286607655/job/31391242329, it seems that with new jiti upgrade we are loading the cjs version of devtools in the prepare step, which is flagging up an issue (
this.nuxt
doesn't work asthis
isn't defined) - cc: @pi0 in case this isn't expectednote, even
this?.nuxt
doesn't work as the dynamic import of./dist/module.mjs
doesn't work in the prepare step (beforedist/module.mjs
has been stubbed out)I think it's safe to remove the cjs stub as it shouldn't be loaded by nuxt but you may have more context.