fix: add rel to props from prose a #1491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Actually, every external links have
rel="nofollow"which is far from ideal in terms of SEO and security.Also, it's impossible to customize the rel for a specific link since remark-mdc automatically add
rel="nofollow". This plugin should not be opinitated about links (nuxtlabs/remark-mdc#71).This PR add rel to ProseA props to restore default NuxtLink behavior. This is a temporary mitigation since the remark-mdc issue should be solved.
In the same time, I'm asking for a whitlist of website, nuxt/nuxt#25466, to help to remove the
noreferrerfrom some links. I think that thenoopener noreferreris not correctly used in NuxtLink.https://stackoverflow.com/questions/50773152/when-should-i-use-rel-noreferrer