Skip to content

Conversation

@vachmara
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This pull request refactors several UI components for improved code clarity, accessibility, and consistency, especially around HomeCard component.

UI Refactoring and Button Improvements:

  • Replaced custom anchor tags with standardized UButton props such as to, label, and external for navigation actions (GitHub/Discord connect, profile sharing), improving accessibility and maintainability.
  • Updated event handling for logout and profile sharing buttons to use Vue’s .stop modifier for click events, ensuring proper event propagation control.
  • Standardized button color and variant usage for Discord badge unlocking and profile sharing actions, removing conditional class logic and using consistent props.

Code and Style Cleanup:

  • Removed the entire <style> block from HomeCard.vue, eliminating unused and redundant CSS classes related to card, button, and checkbox styling.
  • Minor adjustment in app.config.ts to simplify the button border class definition by removing a redundant border width specification.

Minor UI Consistency Fixes:

  • Updated avatar image sources to use contributor.username directly, ensuring consistent avatar rendering.
  • Fixed utility class usage in profile card backgrounds for consistent styling across breakpoints and hover states in [username].vue.

Comment on lines -142 to -146
canUnlockNuxterBadge ? 'primary-button' : 'bg-neutral-900',
{ 'cursor-auto hover:bg-neutral-950': !canUnlockNuxterBadge },
{ 'primary-button-discord': !linked.discord && canUnlockNuxterBadge },
{ 'cursor-auto hover:bg-neutral-950 text-primary-400': linked.discord && canUnlockNuxterBadge },
]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we want to have a different colour if it's possible to unlock the discord badge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like that?
image

@vachmara vachmara requested a review from danielroe November 18, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants