-
Notifications
You must be signed in to change notification settings - Fork 906
feat(ProseImg): improve zoom
transition
#4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
Why is the image transformed in height? Feels a bit weird to not respect the ratio π€ CleanShot.2025-09-19.at.09.28.55.mp4 |
I don't know, I'll dig around to fix this but I don't have the problem on my end with the staging preview π¬ |
3f0c24a
to
c9ba808
Compare
Do you still see a ratio problem with this build? https://ui-fuonba9wo-nuxt-js.vercel.app/docs/typography/images-and-embeds |
@HugoRCD Maybe the component should disable the default zoom when the image is already wrapped in a link? |
I hadn't thought of that thanks π |
zoom
transition
zoom
transitionzoom
transition
@HugoRCD @benjamincanac Should I open another issue about this? |
@maximepvrt I'm not sure how we could detect the image is wrapped in a link, you can just use |
π Linked issue
β Type of change
π Description
https://ui-itk85x0y5-nuxt-js.vercel.app/docs/typography/images-and-embeds
Before:
before.mp4
After:
after.mp4