Skip to content

Conversation

IranMine123
Copy link

@IranMine123 IranMine123 commented Sep 17, 2025

πŸ”— Linked issue

#4819

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

changed locale to 'fa' due to mismatch with BCP-47 standard + language code defined from i18n module is defined as 'fa'

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

changed locale to 'fa' due to mismatch with BCP-37 standard + language code defined from i18n module is defined as 'fa'
@benjamincanac
Copy link
Member

As mentioned in #4819 (comment), I don't think the code is incorrect here. This could also introduce a breaking change.

You're free to define your locales as you want in @nuxtjs/i18n and also use locale fallback for such cases: https://i18n.nuxtjs.org/docs/guide/locale-fallback

@mehotkhan what do you think?

@IranMine123
Copy link
Author

IranMine123 commented Sep 17, 2025

As mentioned in #4819 (comment), I don't think the code is incorrect here. This could also introduce a breaking change.

You're free to define your locales as you want in @nuxtjs/i18n and also use locale fallback for such cases: https://i18n.nuxtjs.org/docs/guide/locale-fallback

@mehotkhan what do you think?

Well for i18n module we should keep the code option to fa because it has another options for fa-IR(like iso).

Although this could be fixed by mapping fa-IR to fa but I don't think it's identical.

EDIT: also since there is no any other fa locales with different region at this time (for example fa-AF) there's no need to put the region for the code

@benjamincanac benjamincanac force-pushed the v4 branch 2 times, most recently from 3f0c24a to c9ba808 Compare September 23, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 #4488
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants