Skip to content

fix(Drawer): use full height/width for snapPoints #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v4
Choose a base branch
from
Open

fix(Drawer): use full height/width for snapPoints #5041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfdc0e1
fix(Drawer): use full height/width for snapPoints
J-Michalek Sep 22, 2025
4ee01df
up
J-Michalek Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/runtime/components/Drawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ const contentEvents = {

const ui = computed(() => tv({ extend: tv(theme), ...(appConfig.ui?.drawer || {}) })({
direction: props.direction,
inset: props.inset
inset: props.inset,
snapPoints: props.snapPoints && props.snapPoints.length > 0
}))
</script>

Expand Down
14 changes: 14 additions & 0 deletions src/theme/drawer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ export default (options: Required<ModuleOptions>) => ({
true: {
content: 'rounded-lg after:hidden overflow-hidden [--initial-transform:calc(100%+1.5rem)]'
}
},
snapPoints: {
true: ''
}
},
compoundVariants: [{
Expand All @@ -43,13 +46,24 @@ export default (options: Required<ModuleOptions>) => ({
content: 'h-auto max-h-[96%]',
handle: '!w-12 !h-1.5 mx-auto'
}
}, {
direction: ['top', 'bottom'],
snapPoints: true,
class: {
content: 'h-full' }
}, {
direction: ['right', 'left'],
class: {
content: 'w-auto max-w-[calc(100%-2rem)]',
handle: '!h-12 !w-1.5 mt-auto mb-auto'
}
}, {
direction: ['right', 'left'],
snapPoints: true,
class: {
content: 'w-full' }
},
{
direction: 'top',
inset: true,
class: {
Expand Down
Loading