Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement C++ version of MonitorStage #1908

Open
wants to merge 46 commits into
base: branch-24.10
Choose a base branch
from

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Sep 24, 2024

Description

Implemented C++ MonitorStage based on indicators library (supports progress bar display)

  • Each MonitorStage displays a progress bar with customized description tag, message unit and (optional) message count method. Customized font is supported.
  • Supports ControlMessage and MessageMeta as input type
  • Able to run multiple MonitorStages within the same pipeline

A quick demo:
Screencast from 10-08-2024 10-23-41 AM (1)

  • Note: indicators library does not have official support for displaying the progress bars with other log output. This PR uses this workaround to enable displaying progress bars alongside other log outputs.

Need to merge nv-morpheus/utilities#78

Closes #804

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv self-assigned this Sep 24, 2024
@yczhang-nv yczhang-nv added non-breaking Non-breaking change feature request New feature or request labels Sep 24, 2024
@yczhang-nv yczhang-nv marked this pull request as ready for review October 1, 2024 23:37
@yczhang-nv yczhang-nv requested review from a team as code owners October 1, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Status: Review - Ready for Review
Development

Successfully merging this pull request may close these issues.

[FEA]: Implement MonitorStage in C++
1 participant