-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement C++ version of MonitorStage
#1908
Open
yczhang-nv
wants to merge
46
commits into
nv-morpheus:branch-24.10
Choose a base branch
from
yczhang-nv:impl-cpp-monitor-stage
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement C++ version of MonitorStage
#1908
yczhang-nv
wants to merge
46
commits into
nv-morpheus:branch-24.10
from
yczhang-nv:impl-cpp-monitor-stage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yczhang-nv
added
non-breaking
Non-breaking change
feature request
New feature or request
labels
Sep 24, 2024
…us into impl-cpp-monitor-stage
…us into impl-cpp-monitor-stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented C++
MonitorStage
based on indicators library (supports progress bar display)MonitorStage
displays a progress bar with customized description tag, message unit and (optional) message count method. Customized font is supported.ControlMessage
andMessageMeta
as input typeMonitorStage
s within the same pipelineA quick demo:
indicators
library does not have official support for displaying the progress bars with other log output. This PR uses this workaround to enable displaying progress bars alongside other log outputs.Need to merge nv-morpheus/utilities#78
Closes #804
By Submitting this PR I confirm: