Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask error in DFP Integrated training pipeline #1931

Conversation

dagardner-nv
Copy link
Contributor

Description

  • FileToDFController now exposes a download_method constructor argument allowing the caller control over the Downloader class's download method.
  • Since the file_to_df_loader module creates and closes a FileToDFController instance on a per-call basis, set download_method=SINGLE_THREAD. Fixes an issue where dask was being shutdown early after the first message.

Closes #1916

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

…oller on a per-call basis set the download method to single-thread, this prevents an issue where dask is closed after processing the first message
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 2, 2024
@dagardner-nv dagardner-nv self-assigned this Oct 2, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner October 2, 2024 22:40
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c7c8b4a into nv-morpheus:branch-24.10 Oct 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: DFP DUO integrated training pipeline fails with dask error in 24.10
2 participants