Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark updates/fixes #1958

Draft
wants to merge 16 commits into
base: branch-24.10
Choose a base branch
from
Draft

Benchmark updates/fixes #1958

wants to merge 16 commits into from

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Fixes benchmark tests that were broken from latest code updates
  • Add pynvml dependency back to conda dev environment. It was removed when nvtabular was removed.
  • Remove broken E2E autoencoder test since Starter DFP is being removed.
  • Update Benchmark README
  • Update to pip install sentence-transformers because conda package was causing some benchmark tests to call CPU pytorch and fail.

Fixes #1943

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 18, 2024
@efajardo-nv efajardo-nv self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@efajardo-nv efajardo-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Conda installs a redundant CPU build of torch
1 participant
@efajardo-nv