Only play sounds or beeps for Remote cues #17852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17849
Summary of the issue:
If set to play beeps instead of sounds, Remote still plays the sound, as well as the beep, when outputting cues.
Description of user facing changes
Only beeps or sounds are played, as appropriate.
Description of development approach
Fixed the logic in
remoteClient.cues._playCue
to have the sound and beep playing code on separate branches.Previously, if playing sounds was selected, the sound was played and the function returned before the beep code was reached. However, this also stopped text cues from being output.
When the premature return was removed, the logic was not updated, resulting in both a beep and sound being heard when beep output was selected.
Testing strategy:
Connected and disconnected Remote with "Play sounds instead of beeps" enabled and disabled in Remote settings.
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary