Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only play sounds or beeps for Remote cues #17852

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Only play sounds or beeps for Remote cues #17852

merged 2 commits into from
Mar 26, 2025

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

Fixes #17849

Summary of the issue:

If set to play beeps instead of sounds, Remote still plays the sound, as well as the beep, when outputting cues.

Description of user facing changes

Only beeps or sounds are played, as appropriate.

Description of development approach

Fixed the logic in remoteClient.cues._playCue to have the sound and beep playing code on separate branches.

Previously, if playing sounds was selected, the sound was played and the function returned before the beep code was reached. However, this also stopped text cues from being output.
When the premature return was removed, the logic was not updated, resulting in both a beep and sound being heard when beep output was selected.

Testing strategy:

Connected and disconnected Remote with "Play sounds instead of beeps" enabled and disabled in Remote settings.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley requested a review from a team as a code owner March 24, 2025 02:55
@SaschaCowley SaschaCowley requested a review from seanbudd March 24, 2025 02:55
@SaschaCowley SaschaCowley changed the title Only play sounds or beeps for Remmote cues Only play sounds or beeps for Remote cues Mar 24, 2025
@seanbudd seanbudd merged commit 5e3ac31 into master Mar 26, 2025
5 checks passed
@seanbudd seanbudd deleted the fixRemoteSound branch March 26, 2025 04:29
@github-actions github-actions bot added this to the 2025.1 milestone Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small problem with NVDA Remote sound
2 participants