Fix crash on newer pythons #1499
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils was removed in python 3.12, causing the import of find_executable to fail. According to the python devs, find_executable was never intended as an external interface to begin with (see python issue #39260[^1]). This replaces it with shutil.which. [^1]: https://bugs.python.org/issue39260#msg359644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils was removed in python 3.12, causing the import of
find_executable to fail. According to the python devs, find_executable
was never intended as an external interface to begin with (see python
issue #392601). This replaces find_executable with shutil.which,
which is available on all pythons supported by thefuck.
Four tox tests fail, but they are not related to this change (and they
failed in the previous version too).
I notice a few other PRs for the same issue; is thefuck still maintained?
Footnotes
https://bugs.python.org/issue39260#msg359644 ↩