Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Workflow failed to build, issue #39 #40

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

w-sx
Copy link
Contributor

@w-sx w-sx commented May 16, 2024

No description provided.

w-sx added 2 commits May 16, 2024 12:24
Signed-off-by: Johnson Murphy <bystfox@outlook.com>
Signed-off-by: Johnson Murphy <bystfox@outlook.com>
@josephsl josephsl merged commit 0cb5234 into nvdaaddons:master May 16, 2024
2 checks passed
@cary-rowen
Copy link

Hi @w-sx

Thank you for contributing this PR.

Here are some small suggestions that may help you:

  1. Fill out the PR description as much as possible, although you already provided useful details in Workflow failed to build #39.
  2. Linking a pull request to an issue using a keyword, When you link a pull request to the issue the pull request addresses, collaborators can see that someone is working on the issue. When your linked pull request is merged into the repository's, its linked issues will automatically be closed. Keywords you can choose include fixed, closed, close, etc. E.G. Closed Workflow failed to build #39

Cheers,
Cary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants