Skip to content

Commit

Permalink
Merge pull request #6 from nventive/feat/make-alb-iternal-attribute-c…
Browse files Browse the repository at this point in the history
…onfigurable

feat: Make ALB `attribute` configurable
  • Loading branch information
jbonnier authored Oct 16, 2023
2 parents e68ea19 + 9a2445f commit 57b01c5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ module "ecs_cluster" {
|------|--------|---------|
| <a name="module_alb_dns_alias"></a> [alb\_dns\_alias](#module\_alb\_dns\_alias) | cloudposse/route53-alias/aws | 0.13.0 |
| <a name="module_kms_key"></a> [kms\_key](#module\_kms\_key) | cloudposse/kms-key/aws | 0.12.1 |
| <a name="module_lb"></a> [lb](#module\_lb) | nventive/lb/aws | 1.0.1 |
| <a name="module_lb"></a> [lb](#module\_lb) | nventive/lb/aws | 1.1.0 |
| <a name="module_this"></a> [this](#module\_this) | cloudposse/label/null | 0.25.0 |
## Resources

Expand All @@ -107,6 +107,7 @@ module "ecs_cluster" {
| <a name="input_alb_arn"></a> [alb\_arn](#input\_alb\_arn) | Set if you want to use an existing Application Load Balancer. | `string` | `""` | no |
| <a name="input_alb_dns_aliases"></a> [alb\_dns\_aliases](#input\_alb\_dns\_aliases) | List of custom domain name aliases for ALB. | `list(string)` | `[]` | no |
| <a name="input_alb_enabled"></a> [alb\_enabled](#input\_alb\_enabled) | Set to false to prevent the module from creating an Application Load Balancer.<br>This setting defaults to false if `alb_arn` is specified. | `bool` | `true` | no |
| <a name="input_alb_internal"></a> [alb\_internal](#input\_alb\_internal) | Set to `true` to make the ALB internal. | `bool` | `false` | no |
| <a name="input_alb_ip_address_type"></a> [alb\_ip\_address\_type](#input\_alb\_ip\_address\_type) | Address type for ALB possible. Specify one of `ipv4`, `dualstack`. Only when `alb_enabled = true`. | `string` | `null` | no |
| <a name="input_attributes"></a> [attributes](#input\_attributes) | ID element. Additional attributes (e.g. `workers` or `cluster`) to add to `id`,<br>in the order they appear in the list. New attributes are appended to the<br>end of the list. The elements of the list are joined by the `delimiter`<br>and treated as a single ID element. | `list(string)` | `[]` | no |
| <a name="input_cloudwatch_log_group_retention_in_days"></a> [cloudwatch\_log\_group\_retention\_in\_days](#input\_cloudwatch\_log\_group\_retention\_in\_days) | Number of days to retain Cloudwatch logs. | `number` | `60` | no |
Expand Down
3 changes: 2 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,12 @@ data "aws_subnet" "lb" {

module "lb" {
source = "nventive/lb/aws"
version = "1.0.1"
version = "1.1.0"
enabled = local.alb_enabled && local.enabled

subnet_ids = var.subnet_ids
ip_address_type = var.alb_ip_address_type
internal = var.alb_internal
load_balancer_type = "application"
enable_http2 = true
security_group_enabled = true
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ variable "alb_arn" {
description = "Set if you want to use an existing Application Load Balancer."
}

variable "alb_internal" {
type = bool
default = false
description = "Set to `true` to make the ALB internal."
}

variable "alb_ip_address_type" {
type = string
default = null
Expand Down

0 comments on commit 57b01c5

Please sign in to comment.