-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CUDA stream handler includes and function names #266
Update CUDA stream handler includes and function names #266
Conversation
2babce8
to
94197e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gigony , does this present a backwards compatibility issue with Holoscan <1.0.3? Have you confirmed that each of the updated apps is fully compatible with the Holoscan >=1.0.3 where the naming changes are introduced?
94197e6
to
8496673
Compare
Thanks @tbirdso for the feedback! I think it wouldn't be backward-compatible with the old version (<1.0.3) because the new methods didn't exist. Looks like Holohub repository is not versioned (tagged).
I tested with only one or two applications in holohub with this change. (I wonder what is the best way to verify each of the applications locally). Besides my mistake of removing |
Thanks @gigony !
Correct, each HoloHub project is versioned individually. We do not currently require all projects update to a new Holoscan version at the same time, though we are exploring clearer maintenance guidance for the future. As a result, unfortunately we would need to determine whether updating each of these affected projects to Holoscan
The current suggested verification procedure for updating a HoloHub project is as follows:
Unfortunately the current process places a rather large burden on developers when suggesting updates across projects like you've put together here. We're looking into ways that we can streamline and otherwise reduce the burden of this process. Ideally, I'll suggest the following:
More practically, if you don't have the time for that right now it's OK to leave this draft open for others to reference as they update their applications to |
Hi @gigony , thanks for your patience. Based on feedback from @jjomier we can move forward with this change. We expect any app breakage (if any) from these updates to v1.0.3 will be caught in our internal dashboard and fixed at that time. Would you please confirm whether we are ready to merge, and resolve the merge conflict? |
@gigony can you look into resolving the conflict? |
We don't update the method names in: gxf_extensions/utils/cuda_stream_handler.hpp This is because the method names are used in codelets (under 'gxf_extensions') and GXF is using camel case for method names. Signed-off-by: Gigon Bae <gbae@nvidia.com>
8496673
to
2c7ef65
Compare
We don't update the method names in: gxf_extensions/utils/cuda_stream_handler.hpp This is because the method names are used in codelets (under 'gxf_extensions') and GXF is using camel case for method names. Signed-off-by: Gigon Bae <gbae@nvidia.com>
…oloscan#266) We don't update the method names in: gxf_extensions/utils/cuda_stream_handler.hpp This is because the method names are used in codelets (under 'gxf_extensions') and GXF is using camel case for method names. Signed-off-by: Gigon Bae <gbae@nvidia.com> Signed-off-by: Rony Rado <rrado@nvidia.com>
The CudaStreamHandler's API has been updated to use underscores, causing warning messages when the old method names are used, starting from version 1.0.
This pull request updates the CUDA stream handler includes and function names in the lstm_tensor_rt_inference, npp_filter, orsi_format_converter, orsi_segmentation_postprocessor, orsi_segmentation_preprocessor, orsi_visualizer, qt_video, and tool_tracking_postprocessor operators to use the new
holoscan/utils/cuda_stream_handler.hpp
header and the new function names with underscores.The changes include:
../utils/cuda_stream_handler.hpp
toholoscan/utils/cuda_stream_handler.hpp
defineParams
todefine_params
,fromMessage
tofrom_message
,getCudaStream
toget_cuda_stream
, andtoMessage
toto_message
.holoscan/utils/cuda_stream_handler.hpp
header.