Skip to content

add --benchmark option in build #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

add --benchmark option in build #447

merged 1 commit into from
Jul 30, 2024

Conversation

sohamm17
Copy link
Contributor

This MR adds a --benchmark option in ./run build so that an application is built with --configure-args -DCMAKE_CXX_FLAGS=-I$PWD/benchmarks/holoscan_flow_benchmarking

@sohamm17 sohamm17 requested review from jjomier and wendell-hom July 28, 2024 04:18
@sohamm17 sohamm17 self-assigned this Jul 28, 2024
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Please rebsae on main and sign commits (git commit -s) to merge

@sohamm17 sohamm17 force-pushed the ss/build_benchmark branch from 80ad70a to ebb3db0 Compare July 29, 2024 18:02
Signed-off-by: sohams <sohams@nvidia.com>

documentation update
patch application automatically when building with --benchmark
removed description from build_desc for benchmarking

Signed-off-by: sohams <sohams@nvidia.com>
@sohamm17 sohamm17 force-pushed the ss/build_benchmark branch from ebb3db0 to 5c9b839 Compare July 29, 2024 18:06
@tbirdso tbirdso merged commit 4c15732 into main Jul 30, 2024
8 checks passed
@tbirdso tbirdso deleted the ss/build_benchmark branch July 30, 2024 13:50
ronyrad pushed a commit to ronyrad/holohub that referenced this pull request Nov 8, 2024
documentation update
patch application automatically when building with --benchmark
removed description from build_desc for benchmarking

Signed-off-by: sohams <sohams@nvidia.com>
Signed-off-by: Rony Rado <rrado@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants