Add Holoviz feature samples #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sRGB example - vsync example This is using cookiecutter to generate the various examples from a template. Signed-off-by: Andreas Heumann <aheumann@nvidia.com>
AndreasHeumann
force-pushed
the
ah/holoviz_examples
branch
from
9eb5a35 to
371303e
Compare
tbirdso
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks @AndreasHeumann .
The cookiecutter approach is interesting. As I understand it, there are multiple planned examples to follow that will use similar boilerplate with manual updates to demonstrate each feature. In that case I see how the cookiecutter makes sense over alternatives like compiler directives or CMake configuration (*.cpp.in) that other HoloHub examples might rely on, which are not as flexible for a wide range of configurable values or for reading source code.
Looks good to me.
applications/holoviz/template/cookiecutter-holoviz/{{cookiecutter.project_slug}}/README.md
Outdated
Show resolved
Hide resolved
tbirdso
reviewed
Jul 31, 2024
…ter.project_slug}}/README.md Minor spelling fix Signed-off-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
Minor spelling fix Signed-off-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
|
Added two minor spelling fixes to avoid them blocking merge. Moving forward with squash & merge. |
ronyrad
pushed a commit
to ronyrad/holohub
that referenced
this pull request
Nov 8, 2024
* Add Holoviz feature samples
- sRGB example
- vsync example
This is using cookiecutter to generate the various examples from
a template.
Signed-off-by: Andreas Heumann <aheumann@nvidia.com>
* Update applications/holoviz/template/cookiecutter-holoviz/{{cookiecutter.project_slug}}/README.md
Minor spelling fix
Signed-off-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
* Update applications/holoviz/holoviz_srgb/README.md
Minor spelling fix
Signed-off-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
---------
Signed-off-by: Andreas Heumann <aheumann@nvidia.com>
Signed-off-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
Co-authored-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
Signed-off-by: Rony Rado <rrado@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using cookiecutter to generate the various examples from a template.