Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no-cache option in dev_container script #478

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mocsharp
Copy link
Contributor

While following the instructions in operators/advanced_network/README.md, I noticed that the dev_container script doesn't support the specified no-cache option.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp requested a review from tbirdso August 26, 2024 17:22
@mocsharp mocsharp self-assigned this Aug 26, 2024
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future we could add a --docker_opts flag to add arbitrary docker options to the build command, similar to what we do in dev_container launch.

@tbirdso tbirdso merged commit a5eaaa9 into nvidia-holoscan:main Aug 26, 2024
3 checks passed
@mocsharp mocsharp deleted the vchang/no-cache-support branch August 26, 2024 17:31
sohamm17 pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Victor Chang <vicchang@nvidia.com>
ronyrad pushed a commit to ronyrad/holohub that referenced this pull request Nov 8, 2024
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Rony Rado <rrado@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants