Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified patch application script to be more explicit in CPP files #587

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sohamm17
Copy link
Contributor

Previously, calls like holoscan::Application() would also be modified (e.g., link)

Made a little change so that it only considers modification when holoscan::Application is being inherited in cpp files.

Signed-off-by: sohams <sohams@nvidia.com>
@sohamm17 sohamm17 added the enhancement New feature or request label Nov 13, 2024
@sohamm17 sohamm17 requested a review from tbirdso November 13, 2024 16:53
@sohamm17 sohamm17 self-assigned this Nov 13, 2024
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tbirdso tbirdso merged commit 1a89322 into main Nov 13, 2024
8 checks passed
@tbirdso tbirdso deleted the ss/patch_modify branch November 13, 2024 17:04
cliffburdick pushed a commit to cliffburdick/holohub that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants