Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared pointer interface #635

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

cliffburdick
Copy link
Contributor

No description provided.

@ronyrad
Copy link
Contributor

ronyrad commented Dec 13, 2024

Looks good to me

@agirault
Copy link
Contributor

History seems a bit wacky. Can you rebase and clean this up to unblock merge? Ty

@agirault
Copy link
Contributor

Also @cliffburdick , could you provide the results of ctest . --verbose in the build directory with no other change to confirm this does not break the test? Thank you!

@cliffburdick
Copy link
Contributor Author

ctest . --verbose

I'm getting 47Gbps and it's failing, but I was only getting 47Gbps on my setup before that. Will look into it.

Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per offline discussion

@tbirdso tbirdso merged commit 9ac961e into nvidia-holoscan:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants