Build: Set default CUDA_ARCHITECTURES for builds
#648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a default `CMAKE_CUDA_ARCHITECTURES` list for builds to inherit that covers most modern architectures. The list here is at parity with Holoscan SDK build defaults. Subprojects in HoloHub may choose to override this value with their own default settings or set `CUDA_ARCHITECTURES` directly on targets. Resolves an observed issue on IGX 1.1 where not setting this property resulted in a default value of "52" in the Multi-AI Ultrasound application, leading to a "PTX" failure message. With this fix the Multi-AI Ultrasound application inherits the updated list of compute capabilities by default. Note that existing builds may need to clear the `CMakeCache.txt` or the specific architectures cache entry to apply the fix. co-authored-by: Wendell Hom <whom@nvidia.com> Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
AndreasHeumann
requested changes
Dec 20, 2024
tbirdso
commented
Dec 31, 2024
jjomier
approved these changes
Jan 2, 2025
|
Moved forward with the "native" stopgap in #651. Let's continue discussion on best practice for a long term fix in this PR. |
Co-authored-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com> Signed-off-by: Andreas Heumann <aheumann@nvidia.com>
|
Closing as duplicate of #651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a default
CMAKE_CUDA_ARCHITECTURESlist for builds to inherit that covers most modern architectures.The list here is at parity with Holoscan SDK build defaults. Subprojects in HoloHub may choose to override this value with their own default settings or set
CUDA_ARCHITECTURESdirectly on targets.Resolves an observed issue on IGX 1.1 where not setting this property resulted in a default value of "52" in the Multi-AI Ultrasound application, leading to a "PTX" failure message. With this fix the Multi-AI Ultrasound
application inherits the updated list of compute capabilities by default.
Note that existing builds may need to clear the
CMakeCache.txtor thespecific architectures cache entry to apply the fix.
Reference: https://cmake.org/cmake/help/v3.24/variable/CMAKE_CUDA_ARCHITECTURES.html