Skip to content

Remove call to install CLI dependencies #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

Remove call to install CLI dependencies #656

merged 1 commit into from
Jan 27, 2025

Conversation

mocsharp
Copy link
Contributor

Since CLI is no longer bundled with HSDK (2.9 and onward), we can remove the call to parse and install CLI dependencies.

@mocsharp
Remove call to install CLI dependencies
c10cb9d 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp self-assigned this Jan 14, 2025
@mocsharp mocsharp added the bug Something isn't working label Jan 14, 2025
tbirdso
tbirdso approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mocsharp . Should this be merged now or when 2.9 releases?

@mocsharp
Copy link
Contributor Author

Thanks @mocsharp . Should this be merged now or when 2.9 releases?

For 2.9 please. Thank you.

@tbirdso tbirdso merged commit 846dfac into nvidia-holoscan:main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@wendell-hom wendell-hom Awaiting requested review from wendell-hom

Assignees

@mocsharp mocsharp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @tbirdso