Build: Replace NGC ZIP archive HTTPS downloads with NGC CLI #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NGC data retrieval to address NGC ZIP HTTPS download support deprecation. As of 2025-01-15 NVIDIA NGC has fully deprecated support for retrieving resources as a ZIP archive via HTTPS tools (curl, wget). This commit updates project CMake calls to `holoscan_download_data` to remove the `https` prefix and prompt the Holoscan SDK `download_ngc_data` script to use the NGC CLI rather than curl or wget to retrieve sample data. MD5 hashsum checks are not supported for NGC CLI downloads with the `download_ngc_data` script as of Holoscan SDK v2.8.0. Developers not developing in the HoloHub container should run `./run setup` on their system to install HoloHub prerequisites including the NGC CLI tool. The Holoscan SDK NGC download script is located at: https://raw.githubusercontent.com/nvidia-holoscan/holoscan-sdk/refs/tags/v2.8.0/scripts/download_ngc_data Affected URLs were identified and replaced with VS Code regex matching: - Find: https://api.ngc.nvidia.com/v2/resources/([a-zA-Z0-9/_-]+)/versions/([0-9a-zA-Z.]+)/zip - Replace: $1:$2 nvidia-holoscan/holoscan-sdk#42 Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
tbirdso
force-pushed
the
ngc-data-fixup
branch
from
54371ca to
c7a1a48
Compare
wendell-hom
approved these changes
Jan 16, 2025
tbirdso
added a commit
that referenced
this pull request
Jan 16, 2025
Update NGC data retrieval to address NGC ZIP HTTPS download support deprecation. As of 2025-01-15 NVIDIA NGC has fully deprecated support for retrieving resources as a ZIP archive via HTTPS tools (curl, wget). This commit updates project CMake calls to `holoscan_download_data` to remove the `https` prefix and prompt the Holoscan SDK `download_ngc_data` script to use the NGC CLI rather than curl or wget to retrieve sample data. MD5 hashsum checks are not supported for NGC CLI downloads with the `download_ngc_data` script as of Holoscan SDK v2.8.0. Developers not developing in the HoloHub container should run `./run setup` on their system to install HoloHub prerequisites including the NGC CLI tool. The Holoscan SDK NGC download script is located at: https://raw.githubusercontent.com/nvidia-holoscan/holoscan-sdk/refs/tags/v2.8.0/scripts/download_ngc_data Affected URLs were identified and replaced with VS Code regex matching: - Find: https://api.ngc.nvidia.com/v2/resources/([a-zA-Z0-9/_-]+)/versions/([0-9a-zA-Z.]+)/zip - Replace: $1:$2 nvidia-holoscan/holoscan-sdk#42 Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NGC data retrieval to address NGC ZIP HTTPS download support deprecation.
As of 2025-01-15 NVIDIA NGC has fully deprecated support for retrieving resources as a ZIP archive via HTTPS tools (curl, wget). This commit updates project CMake calls to
holoscan_download_datato remove thehttpsprefix and prompt the Holoscan SDKdownload_ngc_datascript to use the NGC CLI rather than curl or wget to retrieve sample data. MD5 hashsum checks are not supported for NGC CLI downloads with thedownload_ngc_datascript as of Holoscan SDK v2.8.0.Developers not developing in the HoloHub container should run
./run setupon their system to install HoloHub prerequisites including the NGC CLI tool.The Holoscan SDK NGC download script is located at: https://raw.githubusercontent.com/nvidia-holoscan/holoscan-sdk/refs/tags/v2.8.0/scripts/download_ngc_data
Affected URLs were identified and replaced with VS Code regex matching:
nvidia-holoscan/holoscan-sdk#42