Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stereo_vision app #661

Merged
merged 13 commits into from
Jan 30, 2025
Merged

Add stereo_vision app #661

merged 13 commits into from
Jan 30, 2025

Conversation

wendell-hom
Copy link
Contributor

No description provided.

@wendell-hom wendell-hom requested a review from jjomier January 23, 2025 00:18
@wendell-hom wendell-hom self-assigned this Jan 23, 2025
@wendell-hom wendell-hom force-pushed the jmcleod/streo_vision branch 2 times, most recently from 1bc9233 to 9ccae45 Compare January 23, 2025 03:10
@whom3
Lint fix
abc2141 
Signed-off-by: Wendell Hom <whom@nvidia.com>
whom3 added 2 commits January 24, 2025 12:02
@whom3
Update stereo_vision app to work with build_and_run command
5441d20 
Signed-off-by: Wendell Hom <whom@nvidia.com>
@whom3
Add --source option to allow v4l2 or replayer source
f174142 
Signed-off-by: Wendell Hom <whom@nvidia.com>
whom3 and others added 4 commits January 26, 2025 18:15
@whom3
Support VideoStreamReplayer
3351b21 
Signed-off-by: Wendell Hom <whom@nvidia.com>
@whom3
Remove yolov8 object detection
6714b7b 
Author: Jonathan McLeod
@whom3
Fix lint error
9d48be2 
Signed-off-by: Wendell Hom <whom@nvidia.com>
@jjomier @whom3
Merge branch 'main' into jmcleod/streo_vision
e740ec0
@wendell-hom wendell-hom force-pushed the jmcleod/streo_vision branch 2 times, most recently from 8e7b573 to cd70f73 Compare January 29, 2025 18:57
@whom3
Update gif
3195a7d 
Signed-off-by: Wendell Hom <whom@nvidia.com>
tbirdso
tbirdso requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Left comments.

Given the scope of work, could we set up some minimal frame test CTest coverage for quality control?

applications/stereo_vision/README.md Show resolved Hide resolved
applications/stereo_vision/cpp/crop.cpp Outdated Show resolved Hide resolved
applications/stereo_vision/cpp/crop.cpp Outdated Show resolved Hide resolved
applications/stereo_vision/cpp/crop.cpp Outdated Show resolved Hide resolved
applications/stereo_vision/cpp/ess_processor.cpp Show resolved Hide resolved
applications/stereo_vision/cpp/main.cpp Outdated Show resolved Hide resolved
applications/stereo_vision/cpp/split_video.h Show resolved Hide resolved
applications/stereo_vision/cpp/split_video.h Show resolved Hide resolved
applications/stereo_vision/cpp/undistort_rectify.h Outdated Show resolved Hide resolved
applications/stereo_vision/cpp/tracking_postprocessor.h Outdated Show resolved Hide resolved
wendell-hom and others added 3 commits January 29, 2025 14:37
@wendell-hom @tbirdso
Apply suggestions from code review
191e17d 
Apply suggestions

Co-authored-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
Signed-off-by: wendell-hom <60016436+wendell-hom@users.noreply.github.com>
@whom3
Clean up
9791d27 
Author: Jonathan McLeod
Signed-off-by: Wendell Hom <whom@nvidia.com>
@whom3
Lint fixes
db714c3 
Signed-off-by: Wendell Hom <whom@nvidia.com>
tbirdso
tbirdso approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please consider adding test coverage in the future to ensure quality.

@tbirdso tbirdso merged commit 3458a27 into main Jan 30, 2025
6 checks passed
@tbirdso tbirdso deleted the jmcleod/streo_vision branch January 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@ajkmcleod ajkmcleod ajkmcleod left review comments

@jjomier jjomier jjomier approved these changes

Assignees

@wendell-hom wendell-hom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendell-hom @jjomier @ajkmcleod @tbirdso @whom3