Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Ethernet Sensor bridge peoplenet and bodypose app support #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sunny9661
Copy link

@sunny9661 sunny9661 commented Oct 24, 2024

This PR adds peoplenet and bodypose examples support for Microchip PF boards using IMX477 using Linux sockets

@p-ogrady
Copy link
Collaborator

Thanks for your code submission! Code that gets included in the public repo must have test fixture, ensuring that it runs with "pytest". Please add two new tests that invoke the examples provided here. To do this,

  • Borrow the content from tests/test_linux_tao_peoplenet.py. Don't forget to update the copyright date appropriately. Note that the test calls the example program with "--frame-limit=300" -- if we reach that number of video frames without a fault then the test passes.
  • Change the statement that says "@pytest.mark.skip_unless_imx274" to "@pytest.mark.skip_unless_imx477". Support for that condition is already in the tree. This statement tells the test fixture to skip this test unless it's running on a host that has an IMX477 configuration attached.
  • Build and run the demo container
  • Run "pytest", show that it passes, and verify that it doesn't run your new IMX477 tests
  • Run "pytest --imx477", show that it passes, and verify that it does run your new tests

@@ -0,0 +1,287 @@
# SPDX-FileCopyrightText: Copyright (c) 2023-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date here should just be "2024".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I have made the necessary changes. Please review
Thanks

…upport

Signed-off-by: Sunny B <sunny.bezawada@microchip.com>
Copy link
Collaborator

@p-ogrady p-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! I can merge this if 1) these commits are squashed to a single commit and 2) if you can sign that commit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants