feat(hl): add 'TreesitterContextLineNumberBottom' #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danielkonge
force-pushed
the
context-line-number-bottom
branch
from
0b4576e to
1ce2ae4
Compare
lewis6991
reviewed
Jan 25, 2024
Danielkonge
force-pushed
the
context-line-number-bottom
branch
from
1ce2ae4 to
6641e67
Compare
|
I tried addressing the comments now. Please just let me know if you want to change anything else. (Also, since it is such a small PR I just squashed the commits immediately.) |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #383.
For now I replaced
highlight_bottomwithhighlight_lno_bottom, which will change the current behavior a bit, but also allow for more precise configuration by the user.If you prefer to keep
highlight_bottomas it was, I can add it back in together with the new function.