fix(php): start context from name if begins with an attribute #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przepompownia
changed the title
|
Example for test: <?php
namespace X;
use Attribute;
use ReturnTypeWillChange;
#[Attribute]
class Example
{
#[ReturnTypeWillChange]
public function foo(): void
{
$x = 1;
}
}
#[ReturnTypeWillChange]
function foo(): void
{
$x = 1;
} |
|
Can you add that to the test file? |
|
@lewis6991 test seems to be ready |
Fix method_declaration context Fix for function_definition context Add test for functions Test for class and method
przepompownia
force-pushed
the
php-class-context-start
branch
from
12d41fd to
18fc627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: attribute list can leave no room for class or function name
Solution: start the context from the name