fix(nighly): use get_hl_from_capture for nightly, instead of hl_cache #432
Conversation
|
|
||
| local hl = buf_query.hl_cache[capture] | ||
| local hl --- @type integer | ||
| if buf_query.get_hl_from_capture then |
There was a problem hiding this comment.
It would be undefined on older neovim versions.
There was a problem hiding this comment.
Which versions? We only target the latest release.
There was a problem hiding this comment.
I think not breaking older versions is nice, it can be refactored later. In my other plugins I usually try to have them working on whatever debian/ubuntu stable has, which is 0.7 at the moment.
There was a problem hiding this comment.
Not for a treesitter plugin. Even for Neovim core, treesitter is still considered experimental and the API's are moving quickly.
We can keep this as is, but just note going forward, backwards compatibility is a non-goal.
There was a problem hiding this comment.
Hi. I have lost access to my account @Sam-programs.
Which versions? We only target the latest release.
The function isn't defined in stable, tag latest in the releases page.
Seems to Fix #387
works.mp4
Stable works fine without this.