fix: defer execution to avoid segfaults and fix throttler #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo1321
commented
Nov 17, 2024
| @@ -165,7 +167,6 @@ function M.enable() | |||
|
|
|||
| if config.multiwindow then | |||
| table.insert(update_events, 'WinResized') | |||
| table.insert(update_events, 'WinLeave') | |||
There was a problem hiding this comment.
I can't recall why I used this event for multi-window support. It appears to be unnecessary because it triggers for the window being left (nvim_get_current_win() returns the window that the user is leaving).
lewis6991
reviewed
Nov 17, 2024
apollo1321
changed the title
apollo1321
force-pushed
the
fix-segfault
branch
2 times, most recently
from
1d8a3a7 to
b50f8db
Compare
apollo1321
force-pushed
the
fix-segfault
branch
2 times, most recently
from
01ca79f to
6307099
Compare
lewis6991
reviewed
Dec 4, 2024
apollo1321
force-pushed
the
fix-segfault
branch
from
6307099 to
3ba5d0c
Compare
apollo1321
commented
Dec 4, 2024
| @@ -15,25 +15,52 @@ local all_contexts = {} | |||
| --- @param ms? number | |||
| --- @return F | |||
| local function throttle_by_id(f, ms) | |||
| ms = ms or 200 | |||
| ms = ms or 150 | |||
There was a problem hiding this comment.
Is have decreased throttle timeout a little to compensate previous incorrect behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #522 reliably.
It is inspired by the satellite.nvim plugin https://github.com/lewis6991/satellite.nvim/blob/main/lua/satellite.lua#L74, which is more stable and consistently uses deferred execution. In contrast, the current implementation sometimes uses deferred execution and other times executes callbacks in-place, when they are not throttled.
Also, there was a problem with throttler, the following execution was possible: