Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doom): Add vertical center #476

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

polirritmico
Copy link
Contributor

@polirritmico polirritmico commented Aug 7, 2024

Is working for me without any problem in a lot of config scenarios, but I think it needs more testing.

Since this use the same load_packages code from hyper, but with a return, maybe we could move that into utils or something like theme/packages?

Regards

@glepnir
Copy link
Member

glepnir commented Aug 8, 2024

how it looks like ?

@polirritmico
Copy link
Contributor Author

polirritmico commented Aug 8, 2024

how it looks like ?

Some screenshots:

  • Without config:

Screenshot_20240808_033826

  • Regular font size:

Screenshot_20240808_034052

  • Really small font:

Screenshot_20240808_034121

  • Large font:

Screenshot_20240808_034141

  • With the week day header:

Screenshot_20240808_034821

Screenshot_20240808_034911

Any particular test case?


Edit: Added context description

@polirritmico polirritmico force-pushed the doom-vertical-center branch from 54dc5da to 38aa6bb Compare August 9, 2024 20:53
@polirritmico
Copy link
Contributor Author

I've been using this code from my fork daily for two weeks without any issues.

The only question I have is whether the vertical_center option should be enabled by default or not. Since this doesn't center the preview, perhaps an opt-in approach would be better. What do you think @glepnir?

@polirritmico
Copy link
Contributor Author

Hi! It has been a few months, and I wanted to follow up on this PR. I've been using it from my fork without any issues so far.

Is there any feedback, changes, details, or concerns that need to be addressed in order to finally merge it? If you think it's better not to proceed with this change, especially given the lack of recent activity around it, I have no problem with closing the PR.

With the new year, it feels like a good time to either finalize this by merging or close it and move on.

Thanks!

@glepnir
Copy link
Member

glepnir commented Jan 19, 2025

lets go

@glepnir glepnir merged commit 63e83ad into nvimdev:master Jan 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme doom's content not vertically centered
2 participants