Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback temp files to OS temp directory #177

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apgrc
Copy link
Contributor

@apgrc apgrc commented Aug 25, 2024

Closes #66.

Maybe this should be the default path?

@apgrc
Copy link
Contributor Author

apgrc commented Aug 25, 2024

Run make test | grep Errors but I don't see any errors.

@mochaaP
Copy link
Member

mochaaP commented Aug 26, 2024

I think this is very likely to break linters that require path resolving in order to work (which is why this feature existed in the first place). I think a better workaround is to add an override for certain generators to run mkdir -p before actually executing the external command.

@apgrc
Copy link
Contributor Author

apgrc commented Aug 27, 2024

Those linters would break because the file buffer does not exist, not because of the location of the temp_file, right? If that is the case, how would running make -p solve the problem? The user would need to also save the file.

Do you have some examples of linters that break on those cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to open a file in a non-existing path creates error
2 participants