Add check to nvm profile for nvm path

[sladyn98]

This PR aims to add a check for the profile before adding the path
Closes #2076

[ljharb]

can you elaborate a bit on this? it looks like this is basically just duplicating the block from lines 414-419.

[sladyn98]

Oh yeah, I was thinking about the path checking logic so just thought that we would check if the NVM_DIR/.nvm was in the profile for BASH and ZSH, we would avoid appending it else just append it. If i understood the issue correctly we would like to omit the addition of the path to the profile if it exists right ?

[ljharb]

Yes, but does line 414 not already do that?

[sladyn98]

True how are we to then check the path ? I just thought that we would check it if its bash or zsh

[ljharb]

I guess I'm a bit confused. Why does it matter if it's bash or zsh? The original issue is implying that the current logic (which this PR does not change) is broken, and thus the "sourcing" lines are added more than once.

This implies that the existing check needs to be modified, rather than a new check added, for all shells.

[sladyn98]

 ✓ nvm_check_global_modules
  ✓ nvm_detect_profile
  ✓ nvm_do_install
  ✓ nvm_install_dir
  ✓ nvm_install_with_aliased_dot
  ✓ nvm_install_with_node_version
  ✓ nvm_profile_is_bash_or_zsh
  ✓ nvm_reset
  ✓ nvm_source

Looking at the travis I see that the nvm_check_if_path_exists test does not run here

[ljharb]

ah, you'll need to chmod a+x test/install_script/nvm_check_if_path_exists so that it can be executed :-)

[ljharb]

I've rebased this, and marked it as a draft. Please mark it as ready for review when you think it's ready.

[sladyn98]

@ljharb Do you want me to complete this ?

[ljharb]

@sladyn98 that'd be ideal :-) but if you're not interested then it's fine to leave it open so someone else can pick it up.