Enhance logging system with levels and timestamps #3422
Conversation
S1D007
commented
Sep 11, 2024
S1D007
commented
- Add new logging functions: nvm_log, nvm_debug, nvm_info, nvm_warn, nvm_error
- Implement log levels (DEBUG, INFO, WARN, ERROR)
- Add timestamps to log messages
- Create nvm_run_command for logging command executions
- Implement nvm_time_operation for timing long-running operations
- Add nvm_log_env to log environment information
- Update nvm function to log version and environment on start
- Add new logging functions: nvm_log, nvm_debug, nvm_info, nvm_warn, nvm_error - Implement log levels (DEBUG, INFO, WARN, ERROR) - Add timestamps to log messages - Create nvm_run_command for logging command executions - Implement nvm_time_operation for timing long-running operations - Add nvm_log_env to log environment information - Update nvm function to log version and environment on start
|
This is a pretty large and significant change to make without discussing first… can you elaborate on the use case and the need? |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@S1D007 can you elaborate on the use case and the need for this PR? |
close this one. |
|
… ok, but i'd still like to understand what motivated you to do this unsolicited work in the first place. |
without knowing anything about the code saying explicit won't make anyone feel good. he deserves that nonchalant comment that i had given to him. |
|
@S1D007 that was just a spam comment that was made on over 100 PRs, it wasn't personal and had nothing to do with you. Your response was off topic, so I hid it. Would you answer the question from 6 months ago? |
oh god lol.. ok so for the comment you had given 6 month ago. i had just gone through the nvmsh install or setup bash file and saw few areas where enhancement can be done for further programmers and maintainer. and ofc users will have better experience if they are willing to check the code before executing it.. ps: this works still the same the code is written in better way ans btw better is totally based on person whim |
|
indeed, and for any given project, the only whims that matter wrt code structure are that project's maintainers' :-) ftr, in order to justify the complexity of log levels, i'd want to see cases where the existing logs are noisy, but suppressing them all would hide important information. |
