Skip to content

fix: avoid glob expansion errors when no node versions installed #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tennisleng wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: avoid glob expansion errors when no node versions installed #3741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9449392
fix: enable nullglob to avoid glob expansion errors when no node vers…
Dec 5, 2025
fc05468
refactor: use subshell to isolate nullglob changes
Dec 5, 2025
dc76607
test: add regression test for nullglob issue #3727
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1532,7 +1532,12 @@ nvm_ls() {
SEARCH_PATTERN="$(nvm_echo "${PATTERN}" | command sed 's#\.#\\\.#g;')"
fi
if [ -n "${NVM_DIRS_TO_SEARCH1}${NVM_DIRS_TO_SEARCH2}${NVM_DIRS_TO_SEARCH3}" ]; then
VERSIONS="$(command find "${NVM_DIRS_TO_SEARCH1}"/* "${NVM_DIRS_TO_SEARCH2}"/* "${NVM_DIRS_TO_SEARCH3}"/* -name . -o -type d -prune -o -path "${PATTERN}*" \
# Use subshell to isolate nullglob changes (prevents them from persisting)
# See: https://github.com/nvm-sh/nvm/issues/3727
VERSIONS="$(
# shellcheck disable=SC3044
[ -n "${BASH_VERSION-}" ] && shopt -s nullglob
command find "${NVM_DIRS_TO_SEARCH1}"/* "${NVM_DIRS_TO_SEARCH2}"/* "${NVM_DIRS_TO_SEARCH3}"/* -name . -o -type d -prune -o -path "${PATTERN}*" 2>/dev/null \
| command sed -e "
s#${NVM_VERSION_DIR_IOJS}/#versions/${NVM_IOJS_PREFIX}/#;
s#^${NVM_DIR}/##;
Expand Down
35 changes: 35 additions & 0 deletions test/fast/Listing versions/Running 'nvm ls' with empty versions directory does not error
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/sh
# Regression test for issue #3727
# This test ensures nvm ls works correctly when:
# 1. nullglob is NOT set (default bash behavior)
# 2. No node versions are installed (empty versions directory)
# Previously, this would cause "find: ... No such file or directory" errors

die () { echo "$@" ; exit 1; }

\. ../../../nvm.sh
\. ../../common.sh

# Ensure nullglob is OFF (to test the fix works without it)
# This simulates a user who hasn't set nullglob in their shell
if [ -n "${BASH_VERSION-}" ]; then
shopt -u nullglob 2>/dev/null || true
fi

# Make sure no fake versions exist - empty dir triggers the bug
rm -rf "${NVM_DIR}/versions/node/"* 2>/dev/null
mkdir -p "${NVM_DIR}/versions/node"

# Run nvm ls and capture stderr
OUTPUT="$(nvm ls 2>&1)"
EXIT_CODE=$?

# Should not contain "No such file or directory" error
if echo "$OUTPUT" | grep -q "No such file or directory"; then
die "FAIL: nvm ls produced 'No such file or directory' error with empty versions directory"
fi

# Should succeed (exit 0)
[ "$EXIT_CODE" = "0" ] || die "FAIL: nvm ls exited with code $EXIT_CODE, expected 0"

echo "PASS: nvm ls works with empty versions directory and nullglob disabled"
Loading