ci: use Node.js 18

nwtgck · May 3, 2023 · 4b0bc1f · 4b0bc1f
1 parent 62ccade
commit 4b0bc1f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,12 +22,12 @@ jobs:
         submodules: true
     - uses: actions/setup-node@v3.6.0
       with:
-        node-version: '16'
+        node-version: '18'
     - run: npm ci
     - run: |
         set -xeu
         npm run piping-build
-        ./node_modules/.bin/pkg --out-path=piping-server-pkg-${{ matrix.pkg_target_without_node }} --targets=node16-${{ matrix.pkg_target_without_node }} ./piping-server
+        ./node_modules/.bin/pkg --out-path=piping-server-pkg-${{ matrix.pkg_target_without_node }} --targets=node18-${{ matrix.pkg_target_without_node }} ./piping-server
     - name: tar.gz or zip
       run: |
         set -xeu
@@ -62,8 +62,8 @@ jobs:
       uses: docker/setup-qemu-action@v2
     - run: |
         set -xeu
-        # NOTE: node:16 image causes an error "glob error [Error: EACCES: permission denied, scandir '/root/.npm/_logs'] { ..."
-        docker run --rm -i -v $PWD:/app --platform=linux/arm64/v8 node:14 bash << 'EOF'
+        # NOTE: Using node:18 takes over 21 minutes
+        docker run --rm -i -v $PWD:/app --platform=linux/arm64/v8 node:20 bash << 'EOF'
         set -xeu
         # Install ldid for macos-arm64 signing
         curl -LO https://github.com/ProcursusTeam/ldid/releases/download/v2.1.5-procursus2/ldid_linux_aarch64
@@ -72,7 +72,7 @@ jobs:
         cd /app
         npm ci
         npm run piping-build
-        ./node_modules/.bin/pkg --out-path=piping-server-pkg-${{ matrix.pkg_target_without_node }} --targets=node16-${{ matrix.pkg_target_without_node }} ./piping-server
+        ./node_modules/.bin/pkg --out-path=piping-server-pkg-${{ matrix.pkg_target_without_node }} --targets=node18-${{ matrix.pkg_target_without_node }} ./piping-server
         EOF
     - name: tar.gz or zip
       run: |