Skip to content

Commit

Permalink
Merge branch 'release/0.12.1'
Browse files Browse the repository at this point in the history
  • Loading branch information
nwtgck committed Dec 27, 2022
2 parents 736afb0 + 9193568 commit 111aad5
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
9 changes: 7 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)

## [Unreleased]

## [0.12.1] - 2022-12-27
### Fixed
- Solve memory leak when downloading

## [0.12.0] - 2022-12-26
### Change
- Update dependencies
Expand Down Expand Up @@ -422,8 +426,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
### Added
- First release

[Unreleased]: https://github.com/nwtgck/piping-ui-web/compare/v0.12.0...HEAD
[0.12.0]: https://github.com/nwtgck/piping-ui-web/compare/v0.12.0...v0.11.0
[Unreleased]: https://github.com/nwtgck/piping-ui-web/compare/v0.12.1...HEAD
[0.12.1]: https://github.com/nwtgck/piping-ui-web/compare/v0.12.0...v0.12.1
[0.12.0]: https://github.com/nwtgck/piping-ui-web/compare/v0.11.0...v0.12.0
[0.11.0]: https://github.com/nwtgck/piping-ui-web/compare/v0.10.0...v0.11.0
[0.10.0]: https://github.com/nwtgck/piping-ui-web/compare/v0.9.0...v0.10.0
[0.9.0]: https://github.com/nwtgck/piping-ui-web/compare/v0.8.0...v0.9.0
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "piping-ui",
"version": "0.12.0",
"version": "0.12.1",
"private": true,
"author": "Ryo Ota <nwtgck@nwtgck.org> (https://github.com/nwtgck)",
"scripts": {
Expand Down
3 changes: 3 additions & 0 deletions src/components/DataDownloader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ onMounted(async () => {
aTag.href = `/sw-download/v2#?id=${swDownloadId}`;
aTag.target = "_blank";
aTag.click();
// Without this, memory leak occurs. It consumes as much memory as the received file size.
// Memory still leaks when using `npm run serve`. Build and serve to confirm.
await readableStreamForFileType.cancel();
});
// (base: https://googlechrome.github.io/samples/service-worker/post-message/)
Expand Down

0 comments on commit 111aad5

Please sign in to comment.