-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add githubapp auth #1
base: master
Are you sure you want to change the base?
Conversation
Instead of passing around access token as a global variabler / function argument let the token live as a class variable.
@yurm04 Has this project gone stale? |
@Graborg thanks for your patience. I'm trying to debug some failing tests in Travis CI before reviewing this PR. Sorry again for the delay 🙇♀ |
@Graborg just starting to review and test this PR. When I try to run
I'm currently using: I tested master to make sure app runs there with current versions and seems to work. Could you post your system info and run this branch locally? |
Sure, I'll take a look. might have omitted something. Thanks. |
motivation
This PR removes some minor inconsistencies/bugs but mainly it adds the option of authenticating as github app instead of a single user.
This makes it easier to manage use for organizations, without creating a dedicated user.
What kind of change does this PR introduce?
It add the option of running the service as a Github app. If the argument AUTH_AS_APP is omitted. The service will function as normal.
Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing, already added.