Skip to content

Commit

Permalink
NYX 2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
nyxpay committed Apr 19, 2018
1 parent 9be1aa5 commit 30ba1ed
Show file tree
Hide file tree
Showing 728 changed files with 36,595 additions and 21,502 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ Pull Request Philosophy
Patchsets should always be focused. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture. Please also avoid super pull requests which attempt to do too much, are overly large, or overly complex as this makes review difficult.


###Features
### Features

When adding a new feature, thought must be given to the long term technical debt and maintenance that feature may require after inclusion. Before proposing a new feature that will require maintenance, please consider if you are willing to maintain it (including bug fixing). If features get orphaned with no maintainer in the future, they may be removed by the Repository Maintainer.


###Refactoring
### Refactoring

Refactoring is a necessary part of any software project's evolution. The following guidelines cover refactoring pull requests for the project.

Expand Down Expand Up @@ -85,7 +85,7 @@ In general, all pull requests must:
Patches that change Nyx consensus rules are considerably more involved than normal because they affect the entire ecosystem and so must be preceded by extensive mailing list discussions and have a numbered BIP. While each case will be different, one should be prepared to expend more time and effort than for other kinds of patches because of increased peer review and consensus building requirements.


###Peer Review
### Peer Review

Anyone may participate in peer review which is expressed by comments in the pull request. Typically reviewers will review the code for obvious errors, as well as test out the patch set and opine on the technical merits of the patch. Project maintainers take into account the peer review when determining if there is consensus to merge a pull request (remember that discussions may have been spread out over github, mailing list and IRC discussions). The following language is used within pull-request comments:

Expand Down
20 changes: 17 additions & 3 deletions INSTALL
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
Building Nyx Core

Use the autogen script to prepare the build environment.
After you install the usual build tools and C++ development tools,
Nyx Core also needs some build dependencies which are not always provided
by default by the OS package manager
(in particular BerkeleyDB 4.8 for building with wallet support).

Before trying to build, be sure to read one of these files,
depending on your environment:

doc/build-unix.md
doc/build-openbsd.md
doc/build-osx.md
doc/build-windows.md

After installing the needed dependencies,
use the autogen script to prepare the build environment.

./autogen.sh
./configure
Expand All @@ -12,5 +26,5 @@ https://github.com/nyxpay/nyx-binaries
Always verify the signatures and checksums.

See doc/build-*.md for instructions on building nyxd,
the intended-for-services, no-graphical-interface, reference
implementation of Nyx.
the intended-for-services, no-graphical-interface,
reference implementation of Nyx.
2 changes: 1 addition & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ GZIP_ENV="-9n"

if BUILD_BITCOIN_LIBS
pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = libbitcoinconsensus.pc
pkgconfig_DATA = libnyxconsensus.pc
endif

BITCOIND_BIN=$(top_builddir)/src/nyxd$(EXEEXT)
Expand Down
Loading

0 comments on commit 30ba1ed

Please sign in to comment.